Use fallback implementation for min
, max
#675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min
andmax
are currently explicitly defined forAbstractQuantity
arguments and have their own separate re-implementation ofuconvert
for some reason. However, it turns out that this is unnecessary since the standard fallback implementations ofmin
andmax
already work perfectly fine forAbstractQuantity
, because comparison is also defined. Thus, this simply removes these extra method definitions, which, as a bonus, also provides all of the error checking added in #648 tomin
andmax
as well.