Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Behavior in getVolunteerRanks Query Implementation #2781

Closed
prayanshchh opened this issue Dec 21, 2024 · 5 comments
Closed

Fix Flaky Behavior in getVolunteerRanks Query Implementation #2781

prayanshchh opened this issue Dec 21, 2024 · 5 comments
Assignees
Labels
bug Something isn't working test Testing application

Comments

@prayanshchh
Copy link
Contributor

prayanshchh commented Dec 21, 2024

Describe the bug
Flaky behavior in the getVolunteerRanks query implementation causing inconsistent test results for monthly, descending, name, no limit scenario.

To Reproduce
Steps to reproduce the behavior:

  1. run npx vitest tests/resolvers/Query/getVolunteerRanks.spec.ts

Expected behavior
all tests should pass

Actual behavior
getVolunteerRanks for monthly, descending, name, no limit test is failing

Screenshots
image
Additional details

the issue is in the implementation of getVolunteerRanks query rather than the test itself
Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@prayanshchh prayanshchh added the bug Something isn't working label Dec 21, 2024
@github-actions github-actions bot added test Testing application unapproved Unapproved for Pull Request labels Dec 21, 2024
@prayanshchh
Copy link
Contributor Author

assign

@varshith257 varshith257 removed the unapproved Unapproved for Pull Request label Dec 21, 2024
@Aad1tya27
Copy link

The issue has already been fixed in the PR #2770

@varshith257
Copy link
Member

varshith257 commented Dec 21, 2024

We need to fix implementation not a test. It has been marked as flaky

@Aad1tya27
Copy link

I think the actual answer should be 6 only, I've explained it in a comment in my pr. I had changed the expected answer to be equal to 6 in it.

@prayanshchh
Copy link
Contributor Author

I think the actual answer should be 6 only, I've explained it in a comment in my pr. I had changed the expected answer to be equal to 6 in it.

yes u are right, the implemetation seems fine, I slacked @varshith257

@varshith257 varshith257 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-API (Tests) Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Testing application
Projects
Archived in project
Development

No branches or pull requests

3 participants