Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup]: Remove unused code #57

Merged
merged 10 commits into from
Apr 25, 2022
Merged

[Cleanup]: Remove unused code #57

merged 10 commits into from
Apr 25, 2022

Conversation

blindaa121
Copy link
Collaborator

@blindaa121 blindaa121 commented Apr 21, 2022 •
edited
Loading

Description

  • Remove instances of manual authentication
    • Removed plugin options: showExecuteButton, showManualAuthentication
    • Removed components: <Execute />, <Authorization />
  • Remove docusaurus-plugin-proxy package
  • Remove docusaurus-preset-openapi package

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@blindaa121 blindaa121 self-assigned this Apr 21, 2022
@github-actions
Copy link

github-actions bot commented Apr 21, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit ef20cec):

https://docusaurus-openapi-36b86--pr57-n3kselaf.web.app

(expires Wed, 25 May 2022 16:54:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@blindaa121 blindaa121 added enhancement New feature or request DO NOT MERGE labels Apr 21, 2022
@sserrata sserrata closed this Apr 22, 2022
@sserrata sserrata reopened this Apr 22, 2022
@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

Size Change: -12.7 kB (-1%)

Total Size: 2.36 MB

Filename Size Change
demo/build/assets/css/styles.********.css 86.2 kB +88 B (0%)
demo/build/assets/js/2695.********.js 0 B -1.02 kB (removed) 🏆
demo/build/assets/js/4685.********.js 0 B -1.1 MB (removed) 🏆
demo/build/assets/js/4c5e977b.********.js 29.6 kB -6.35 kB (-18%) 👏
demo/build/assets/js/5456.********.js 0 B -10 kB (removed) 🏆
demo/build/assets/js/main.********.js 392 kB -234 B (0%)
demo/build/assets/js/168.********.js 1.09 MB +1.09 MB (new file) 🆕
demo/build/assets/js/2391.********.js 10 kB +10 kB (new file) 🆕
demo/build/assets/js/6119.********.js 1.02 kB +1.02 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
demo/.docusaurus/globalData.json 9.3 kB 0 B
demo/build/assets/js/03d773ca.********.js 572 B 0 B
demo/build/assets/js/05098950.********.js 9.84 kB -5 B (0%)
demo/build/assets/js/0e384e19.********.js 2.39 kB -1 B (0%)
demo/build/assets/js/135394ac.********.js 11.6 kB -5 B (0%)
demo/build/assets/js/13f7b013.********.js 15.3 kB -2 B (0%)
demo/build/assets/js/14eb3368.********.js 8 kB -2 B (0%)
demo/build/assets/js/17896441.********.js 12.8 kB -5 B (0%)
demo/build/assets/js/18c41134.********.js 14.7 kB 0 B
demo/build/assets/js/1a9c2752.********.js 16.6 kB -5 B (0%)
demo/build/assets/js/1be78505.********.js 10.8 kB 0 B
demo/build/assets/js/1e4232ab.********.js 3.45 kB -1 B (0%)
demo/build/assets/js/1f391b9e.********.js 2.6 kB -1 B (0%)
demo/build/assets/js/1f41b3da.********.js 11.6 kB 0 B
demo/build/assets/js/267885ec.********.js 20.1 kB -5 B (0%)
demo/build/assets/js/271404ad.********.js 15.8 kB -5 B (0%)
demo/build/assets/js/2b85808b.********.js 427 B 0 B
demo/build/assets/js/393be207.********.js 920 B -1 B (0%)
demo/build/assets/js/3a924100.********.js 17.9 kB -4 B (0%)
demo/build/assets/js/3d193392.********.js 2.53 kB -5 B (0%)
demo/build/assets/js/3f30461f.********.js 11 kB -4 B (0%)
demo/build/assets/js/3f7c113d.********.js 29.5 kB -6 B (0%)
demo/build/assets/js/4151a9a3.********.js 20.7 kB -5 B (0%)
demo/build/assets/js/533a09ca.********.js 2.79 kB -1 B (0%)
demo/build/assets/js/5547b4e6.********.js 17.6 kB -6 B (0%)
demo/build/assets/js/556fa72d.********.js 1.54 kB -4 B (0%)
demo/build/assets/js/5c868d36.********.js 3.52 kB -1 B (0%)
demo/build/assets/js/6a1cccb8.********.js 1.47 kB -4 B (0%)
demo/build/assets/js/6e5387e3.********.js 8.71 kB -5 B (0%)
demo/build/assets/js/70090257.********.js 20.4 kB -5 B (0%)
demo/build/assets/js/7608cde2.********.js 1.16 kB -1 B (0%)
demo/build/assets/js/7df67612.********.js 16.4 kB -5 B (0%)
demo/build/assets/js/7fb2c1f3.********.js 2.44 kB -5 B (0%)
demo/build/assets/js/822bd8ab.********.js 3.19 kB -1 B (0%)
demo/build/assets/js/888b62d9.********.js 1.3 kB -1 B (0%)
demo/build/assets/js/8906f45a.********.js 9.95 kB -5 B (0%)
demo/build/assets/js/8a18f3bf.********.js 17.1 kB -5 B (0%)
demo/build/assets/js/8c7cea15.********.js 19.6 kB -5 B (0%)
demo/build/assets/js/935f2afb.********.js 3.54 kB 0 B
demo/build/assets/js/960b46e9.********.js 22.3 kB -5 B (0%)
demo/build/assets/js/9719473f.********.js 1.16 kB -1 B (0%)
demo/build/assets/js/99178e05.********.js 11 kB -5 B (0%)
demo/build/assets/js/9e4087bc.********.js 1.61 kB 0 B
demo/build/assets/js/a8b9f4aa.********.js 10.3 kB -5 B (0%)
demo/build/assets/js/b2f554cd.********.js 121 B 0 B
demo/build/assets/js/b549f425.********.js 4.7 kB -3 B (0%)
demo/build/assets/js/bfdd0584.********.js 9.61 kB -4 B (0%)
demo/build/assets/js/c4f5d8e4.********.js 72.3 kB -1 B (0%)
demo/build/assets/js/c771eeef.********.js 11.8 kB -5 B (0%)
demo/build/assets/js/c97f956e.********.js 2.15 kB -5 B (0%)
demo/build/assets/js/cc12b702.********.js 405 B 0 B
demo/build/assets/js/cf404dba.********.js 442 B 0 B
demo/build/assets/js/common.********.js 125 kB -20 B (0%)
demo/build/assets/js/d5bd4b02.********.js 4.41 kB -4 B (0%)
demo/build/assets/js/dff1c289.********.js 4.19 kB -2 B (0%)
demo/build/assets/js/e44a2883.********.js 5.45 kB -1 B (0%)
demo/build/assets/js/e7f14080.********.js 6.91 kB -4 B (0%)
demo/build/assets/js/f55d3e7a.********.js 3.01 kB -1 B (0%)
demo/build/assets/js/runtime~main.********.js 6.57 kB -1 B (0%)
demo/build/index.html 72.6 kB +2 B (0%)

compressed-size-action

@blindaa121 blindaa121 mentioned this pull request Apr 22, 2022
Closed
8 tasks
@blindaa121 blindaa121 requested review from sserrata and csestito April 22, 2022 22:05
sserrata
sserrata approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bryan this looks good. If you can cleanup the commit history, even better. 🚀

@blindaa121 blindaa121 merged commit 20df91d into panw-main Apr 25, 2022
@blindaa121 blindaa121 deleted the code-cleanup-v2 branch April 25, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sserrata sserrata sserrata approved these changes

@csestito csestito Awaiting requested review from csestito

Assignees

@blindaa121 blindaa121

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blindaa121 @sserrata