Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reorder VM-Series interfaces in examples #108

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Nov 20, 2024

Description

This PR swaps VM-Series private and public interfaces (changes the order) to match Azure VM-Series design guide. It also swaps IP addressing between public and private subnets.

Motivation and Context

Compatibility with design guide.

How Has This Been Tested?

Locally.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the enhancement New feature or request label Nov 20, 2024
@acelebanski acelebanski marked this pull request as ready for review November 27, 2024 10:13
@acelebanski acelebanski requested a review from a team as a code owner November 27, 2024 10:13
@acelebanski acelebanski merged commit 47f6a24 into main Nov 27, 2024
20 checks passed
@acelebanski acelebanski deleted the vmseries-interface-reorder-feat branch November 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants