Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict maximum AzureRM provider version for bootstrap module #93

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Sep 13, 2024

Description

This PR adds a new AzureRM provider version constraint that limits maximum provider version to 3.114 in the bootstrap module (temporary solution) due to a provider bug.

Motivation and Context

Our examples utilising bootstrap module currently are not idempotent with the newest AzureRM provider within v3 major branch. It's fixed in AzureRM provider v4 (which is going to be introduced in the next minor version release). Temporarily we need to restrict the maximum version before the bug was introduced.

How Has This Been Tested?

ChatOps

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the bug Something isn't working label Sep 13, 2024
@acelebanski
Copy link
Contributor Author

acelebanski commented Sep 13, 2024

/idempotence paths="examples/dedicated_vmseries"

Testing job ID: 10847188444
Job result: SUCCESS

@acelebanski acelebanski marked this pull request as ready for review September 13, 2024 10:39
@acelebanski acelebanski requested a review from a team as a code owner September 13, 2024 10:39
@acelebanski acelebanski merged commit e5f4170 into main Sep 13, 2024
64 of 67 checks passed
@acelebanski acelebanski deleted the provider-bootstrap-issue-fix branch September 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants