Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Clip L Skip (with SDXL models) is not working. #12

Closed
4 of 6 tasks
sashasubbbb opened this issue Jul 13, 2024 · 4 comments
Closed
4 of 6 tasks

[Bug]: Clip L Skip (with SDXL models) is not working. #12

sashasubbbb opened this issue Jul 13, 2024 · 4 comments

Comments

@sashasubbbb
Copy link

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Enabling Clip Skip SDXL (sdxl_clip_l_skip) in Settings and changing Clip Skip generates the same image on SDXL based checkpoint.

Steps to reproduce the problem

  1. Enable sdxl_clip_l_skip in Settings.
  2. Set Clip Skip to 1.
  3. Generate an image with SDXL model.
  4. Set Clip Skip to 2.
  5. Generate an image with same settings.
  6. Compare images.

What should have happened?

Second image should differ from first one.

According to my tests on A1111 ( AUTOMATIC1111/stable-diffusion-webui#15992 ), image generated with disabled sdxl_clip_l_skip (and any Clip Skip) is the same as with enabled sdxl_clip_l_skip and Clip Skip set to 2.

What browsers do you use to access the UI ?

Google Chrome

Sysinfo

sysinfo-2024-07-13-02-23.json

Console logs

Nothing unusual when changing Clip Skip settings.

Additional information

No response

@Panchovix
Copy link
Owner

Thanks for the report. The PR is applied as the same as on A1111 (2e7bc0a), so at the moment, I'm not sure why it doesn't works sadly. Gonna check if I can manage to find why.

@Panchovix
Copy link
Owner

Okay I think it was faster than I expected. Did a new commit (modified forge_clip.py), can you test if it works now? 30b516a

@sashasubbbb
Copy link
Author

Looks like it's working now, thank you.

@Panchovix
Copy link
Owner

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants