Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PlayerTrade/PurchaseEvent visual issue when being cancelled #11730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PlayerTrade/PurchaseEvent visual issue when being cancelled #11730

wants to merge 1 commit into from

Conversation

HaHaWTH
Copy link
Contributor

@HaHaWTH HaHaWTH commented Dec 11, 2024 •
edited
Loading

This pull request fixes #11693.

Changes made

Fixes client-side visual issues when cancelling PlayerTradeEvent/PlayerPurchaseEvent by resending merchant offer packets.

To reproduce

Make a plugin that cancels PlayerTradeEvent like this code snippet:

@EventHandler
 public void onPlayerTrade(PlayerTradeEvent event) {
      event.setCancelled(true);
      event.setRewardExp(false);
      event.setIncreaseTradeUses(false);
 }

@HaHaWTH HaHaWTH requested a review from a team as a code owner December 11, 2024 19:10
@HaHaWTH HaHaWTH changed the title Fix PlayerTradeEvent visual issue when being cancelled Fix PlayerTrade/PurchaseEvent visual issue when being cancelled Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pre-softspoon
Projects
Paper PR Queue
Status: Awaiting review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelling PlayerTradeEvent levels up the villager and locks trades
2 participants
@HaHaWTH @MiniDigger