Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect.STEP_SOUND is actually the block break effect #12082

Open
spring-dependency-management opened this issue Feb 8, 2025 · 0 comments · May be fixed by #12169
Open

Effect.STEP_SOUND is actually the block break effect #12082

spring-dependency-management opened this issue Feb 8, 2025 · 0 comments · May be fixed by #12169
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.4 Game version 1.21.4

Comments

@spring-dependency-management
Copy link
Contributor

spring-dependency-management commented Feb 8, 2025

Expected behavior

levelevent id 2001 should be PARTICLES_DESTROY_BLOCK, which spawns block break particles and makes the noise, but

Observed/Actual behavior

in the effect api its

  /**
     * Sound of a block breaking. Needs {@link org.bukkit.block.data.BlockData} as additional info.
     */
    STEP_SOUND(2001, Type.SOUND, org.bukkit.block.data.BlockData.class, Material.class), // Paper - block data is more correct, but the impl of the mtehods will still work with Material

Steps/models to reproduce

N/A

Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.4-DEV-main@742968e (1970-01-01T00:00:00Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are 1 version(s) behind
Download the new version at: https://papermc.io/downloads/paper

Other

Used in breakNaturally:

 @Override
    public boolean breakNaturally(ItemStack item, boolean triggerEffect, boolean dropExperience) {
      ...
                    this.world.levelEvent(net.minecraft.world.level.block.LevelEvent.PARTICLES_DESTROY_BLOCK, this.position, net.minecraft.world.level.block.Block.getId(iblockdata));
                }
@papermc-sniffer papermc-sniffer bot added the version: 1.21.4 Game version 1.21.4 label Feb 8, 2025
@Machine-Maker Machine-Maker added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Feb 17, 2025
@Lulu13022002 Lulu13022002 linked a pull request Feb 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.4 Game version 1.21.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants