Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Namespaces support in v3.0 #31

Closed
Papooch opened this issue Jun 19, 2022 · 2 comments · Fixed by #36 or #45
Closed

Remove Namespaces support in v3.0 #31

Papooch opened this issue Jun 19, 2022 · 2 comments · Fixed by #36 or #45
Assignees
@Papooch
Milestone
3.0

Comments

@Papooch
Copy link
Owner

Papooch commented Jun 19, 2022

Namespaces are a remnant from the early implementation based on cls-hooked, but I've never found an useful application for them, therefore I've decided to remove them to clean up the code base and re-use the API in favor of #30
@Papooch Papooch self-assigned this Jun 19, 2022
@Papooch Papooch added this to the 3.0 milestone Jun 19, 2022
@Papooch Papooch changed the title Remove Namespace support in v3.0 Remove Namespaces support in v3.0 Jun 19, 2022
@Papooch
Copy link
Owner Author

Papooch commented Jun 19, 2022

Namespaces have been marked as deprecated in #32

@Papooch Papooch linked a pull request Jun 25, 2022 that will close this issue
Remove namespaces support #36
Merged
@Papooch
Copy link
Owner Author

Papooch commented Sep 9, 2022 •
edited
Loading

There should still be a guide on how to provide a "namespaced" ClsService in the docs though. One use case would be to store a transaction object there - the lifetime of a transaction can be different to the one of a web request.

@Papooch Papooch linked a pull request Oct 4, 2022 that will close this issue
Release/3.0 #45
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Papooch Papooch

Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Remove namespaces support Papooch/nestjs-cls
Release/3.0 Papooch/nestjs-cls
1 participant
@Papooch