Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eslint #10170

Merged
merged 5 commits into from
Aug 28, 2024
Merged

chore: bump eslint #10170

merged 5 commits into from
Aug 28, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Aug 28, 2024

Description

eslint kept throwing errors & running out of memory.
our version is 3 years behind latest, so i bumped it.
it added a bunch of rules, but i removed most of them so we don't have to migrate too much.
there were some rules that were really useful, so for those i modified the offending lines.
in other cases, the rules got intelligent and the lines that used to offend no longer do, so i removed the eslint-disable call.

the biggest change is they changed the shape of the config files.

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick mattkrick merged commit 002aac2 into master Aug 28, 2024
7 checks passed
@mattkrick mattkrick deleted the fix/eslint branch August 28, 2024 21:37
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
24 tasks
Copy link

sentry-io bot commented Aug 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useEditorState fired in last 20ms. {"parsedContent":{"blocks":[{"key":"64s9s","text":"We chat, we... <anonymous>(packages/client/hooks/useEditorState) View Issue
  • ‼️ Error: useEditorState fired in last 20ms. {"parsedContent":{"blocks":[{"key":"c6b5u","text":"Берем задач... <anonymous>(packages/client/hooks/useEditorState) View Issue
  • ‼️ Error: useEditorState fired in last 20ms. {"parsedContent":{"blocks":[{"key":"aamqv","text":"What was yo... 96132/useEditorState/<(packages/client/hooks/us... View Issue
  • ‼️ Error: useEditorState fired in last 20ms. {"parsedContent":{"blocks":[{"key":"3e67n","text":"Have you ev... <anonymous>(packages/client/hooks/useEditorState) View Issue
  • ‼️ Error: useEditorState fired in last 20ms. {"parsedContent":{"blocks":[{"key":"1vb9g","text":"Калькуляция... <anonymous>(packages/client/hooks/useEditorState) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant