Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rethinkdb): Comment: Phase 2 #10180

Merged
merged 8 commits into from
Sep 6, 2024
Merged

chore(rethinkdb): Comment: Phase 2 #10180

merged 8 commits into from
Sep 6, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Aug 29, 2024

Description

migrates existing rows

NOTE:
during phase 1 we encountered a severe bug in prod. This was initially fixed by manually removing a FK constraint in PG and then hotfixed in #10178.

I don't like manually adjusting the PG schema in realtime, but the bug was REALLY bad and by removing that constraint live, we were able to get meetings working again in a second vs 15 minutes.

Before merging this, I will readd the following constraint:

CONSTRAINT "fk_discussionId"
        FOREIGN KEY("discussionId")
          REFERENCES "Discussion"("id")
          ON DELETE CASCADE

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick mattkrick merged commit 9148205 into master Sep 6, 2024
9 checks passed
@mattkrick mattkrick deleted the chore/Comment-phase2 branch September 6, 2024 20:38
@github-actions github-actions bot mentioned this pull request Sep 6, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant