Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orgAdmin): search in org members page #10187

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Sep 3, 2024

Description

Fixes #10185

Demo

2024-09-03 14 53 53

Testing scenarios

  • Search by name
    • Go to org members page: http://localhost:3000/me/organizations/xxxx/members
    • Type something in the search bar
    • Observed name matched members present

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe linked an issue Sep 3, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot added the size/s label Sep 3, 2024
@tianrunhe tianrunhe marked this pull request as ready for review September 3, 2024 22:02
@tianrunhe tianrunhe merged commit 968452e into master Sep 4, 2024
8 checks passed
@tianrunhe tianrunhe deleted the feat/10185/searchOrgMemberPage branch September 4, 2024 15:53
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can search in the org members page
2 participants