Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an archive checkbox in timeline history page #10435

Merged
merged 14 commits into from
Nov 7, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Oct 30, 2024

Description

  • feat: add archive checkbox in timeline history
  • fix: fix the bug where user cannot archive poker or team prompt meetings
  • fix: fix an issue where archived timeline event history did not get removed immediately from the view
  • fix: fix the issue where newly ended meeting won't show up on timeline event list

Demo

2024-10-31 11 47 56

Testing scenarios

  • Toggle archive checkbox in timeline history

    • Go to http://localhost:3000/me
    • Toggle the archive checkbox to display/hide archived timeline history
  • Archive a meeting card

    • Click the 3 dot menu of a completed meeting card
    • Archive the meeting
    • See the card disappears
    • Check the archive checkbox to see the newly archived meeting card

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe changed the title feat/meetingHistoryArchiveBox feat: add an archive checkbox in timeline history page Oct 30, 2024
@tianrunhe tianrunhe marked this pull request as ready for review October 30, 2024 22:51
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things:

packages/client/components/TimelineHeader.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/m and removed size/s labels Nov 4, 2024
@Dschoordsch
Copy link
Contributor

Nice work!

@tianrunhe tianrunhe merged commit 12f3347 into master Nov 7, 2024
6 checks passed
@tianrunhe tianrunhe deleted the feat/meetingHistoryArchiveBox branch November 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants