Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

come up with a meeting side effect mutaiton pattern #1988

Closed
mattkrick opened this issue Apr 11, 2018 · 2 comments
Closed

come up with a meeting side effect mutaiton pattern #1988

mattkrick opened this issue Apr 11, 2018 · 2 comments
Assignees

Comments

@mattkrick
Copy link
Member

mattkrick commented Apr 11, 2018

right now, navigating the meeting can trigger different side effects based on where the meeting has been navigated from/to.

those side effects have a wide arrange of payloads ranging from nothing to just about the entire meeting.

we need a clean way to send those messages to the client.

options:

  • trigger 2 mutations from the client
  • piggyback the side effect on a similar mutation payload (current)
  • create a new payload to address the side effect and have the client sub to that. (still not great because it's not progressive. it fully relies on subscriptions to be functional)
  • inject the result into the navigate payload & just null it out if it's not necessary (this may be the best?)
  • ???

the problem with injecting into the mutation payload is that it's not deferred.

@mattkrick mattkrick self-assigned this Apr 11, 2018
@jordanh
Copy link
Contributor

jordanh commented Apr 19, 2018

Ah. Glad I deferred thinking about this until I had some headspace on the plane. I think #4 here seems to be best, because the side-effect seems to be closest to the action causing it (navigation). That's what you chose, ya?

@mattkrick
Copy link
Member Author

yep, that's the one i chose!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants