Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing user invitation email generation to the background #221

Closed
jordanh opened this issue Aug 24, 2016 · 0 comments
Closed

Pushing user invitation email generation to the background #221

jordanh opened this issue Aug 24, 2016 · 0 comments
Milestone

Comments

@jordanh
Copy link
Contributor

jordanh commented Aug 24, 2016

Issue - Enhancement

We currently render email invitations within the inviteTeamMembers mutation, blocking the return of the graphql call – causing the client to wait while the server does its work.

We should instead enqueue this work and run it in a background task. There are a few options:

  1. Use node-threads-a-gogo to spawn a new thread
  2. Spawn a subprocess for this work – a step toward an email micro-service perhaps (perhaps using child-process-promise
  3. Use a new/light rethinkdb-backed job queue like node-rethink-job-queue
  4. Use a tried-and-true redis-backed job queue like bull
  5. Some other option?

3 looks like the most obvious option, any other opinions?

@mattkrick what chu think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant