You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
notice the flicker & the fonts that got double requested from the server
I think the solution is to make a PR to aphrodite for global styles, since currently how they load fonts is kinda hacky (it's the only bad thing about the whole entire package).
There is a PR from a khan academy staff in the works, but it hasn't been accepted yet & IMO it does some dangerous stuff (eg lets users mix global styles and modular ones in the same call). I voiced my concern & a way to fix it, but no reply yet.
I could fork that PR & write up a injectGlobal function for it, but who knows if they'll accept it or not, and if not, then we'll be running off a fork indefinitely...
The text was updated successfully, but these errors were encountered:
Steps to reproduce:
I think the solution is to make a PR to aphrodite for global styles, since currently how they load fonts is kinda hacky (it's the only bad thing about the whole entire package).
There is a PR from a khan academy staff in the works, but it hasn't been accepted yet & IMO it does some dangerous stuff (eg lets users mix global styles and modular ones in the same call). I voiced my concern & a way to fix it, but no reply yet.
I could fork that PR & write up a
injectGlobal
function for it, but who knows if they'll accept it or not, and if not, then we'll be running off a fork indefinitely...The text was updated successfully, but these errors were encountered: