Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font loads twice error #351

Closed
mattkrick opened this issue Oct 6, 2016 · 2 comments
Closed

Font loads twice error #351

mattkrick opened this issue Oct 6, 2016 · 2 comments
Assignees
Labels

Comments

@mattkrick
Copy link
Member

Steps to reproduce:

  • start a meeting
  • get all the way through to last call
  • go back to check in
  • hit refresh
  • click Updates on the sidebar
  • notice the flicker & the fonts that got double requested from the server

I think the solution is to make a PR to aphrodite for global styles, since currently how they load fonts is kinda hacky (it's the only bad thing about the whole entire package).
There is a PR from a khan academy staff in the works, but it hasn't been accepted yet & IMO it does some dangerous stuff (eg lets users mix global styles and modular ones in the same call). I voiced my concern & a way to fix it, but no reply yet.
I could fork that PR & write up a injectGlobal function for it, but who knows if they'll accept it or not, and if not, then we'll be running off a fork indefinitely...

@mattkrick mattkrick added the bug label Oct 6, 2016
@mattkrick mattkrick self-assigned this Oct 6, 2016
@ackernaut
Copy link
Member

@mattkrick thanks for working on this!

@mattkrick
Copy link
Member Author

This will land in Khan/aphrodite#157. It still requires a few more unit tests before they'll merge. Until then we'll just use the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants