Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cypress Tests that fail in CI #3799

Closed
1 task
mattkrick opened this issue Apr 30, 2020 · 2 comments
Closed
1 task

Fix Cypress Tests that fail in CI #3799

mattkrick opened this issue Apr 30, 2020 · 2 comments
Assignees
@ackernaut
Labels
bug

Comments

@mattkrick
Copy link
Member

Cypress tests fail in CI: https://circleci.com/gh/ParabolInc/parabol/8996
Currently I'm ignoring the tests so I can push to staging.

Looks like there are a few causes. 1 is the rate limiter gets triggered, we need a request to not go out to google when in test mode.

AC

  • Tests pass in CI

Estimate: 6 hours
@mattkrick mattkrick added the bug label Apr 30, 2020
@mattkrick mattkrick added this to the Bug (Non-Critical) milestone Apr 30, 2020
@NikAiyer
Copy link
Contributor

PR #3869 Fixes the rate limit issue

This was referenced Jun 30, 2020
Merged
Merged
@NikAiyer
Copy link
Contributor

PR #3907 fixes the issue with failing tests in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ackernaut ackernaut

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ackernaut @mattkrick @NikAiyer