Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action.parabol.co hardcoded in app #8549

Closed
1 task
mattkrick opened this issue Jul 19, 2023 · 4 comments · Fixed by #9186
Closed
1 task

Remove action.parabol.co hardcoded in app #8549

mattkrick opened this issue Jul 19, 2023 · 4 comments · Fixed by #9186
Labels
bug p3 Should be addressed when able

Comments

@mattkrick
Copy link
Member

mattkrick commented Jul 19, 2023

Our app is deployed to many hosts.
It's here, but also other places: https://github.com/ParabolInc/parabol/blob/b656e7d44061aabd78abadfb05e79d61de9bd181/packages/client/modules/email/components/SummaryEmail/MeetingSummaryEmail/LogoFooter.tsx

AC

  • use process.env.HOST instead
@mattkrick mattkrick added the bug label Jul 19, 2023
@mwermuth mwermuth added p3 Should be addressed when able Squad - Land & Expand labels Jul 25, 2023
@mattkrick
Copy link
Member Author

#8557 (review)

@BartoszJarocki
Copy link
Contributor

@mattkrick should we remove this from our squad board then?

@mattkrick
Copy link
Member Author

sure, i'll take this one. still not sure what to do with those static assets that aren't directly tied to a build, but we'll figure something out!

@mattkrick
Copy link
Member Author

Plan of attack:

  • put EVERYTHING in the build
  • push all assets to the same bucket, do not use a versioned subdirectory (already done in chore: Build once, run everywhere #8557)
  • optional: check if exists before pushing to speed up pushes
  • when webpack touches images, keep their file name or maybe filename + a content hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p3 Should be addressed when able
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants