Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing jira-attachments will result in a 5xx #9111

Closed
2 tasks
mattkrick opened this issue Nov 2, 2023 · 5 comments · Fixed by #9278
Closed
2 tasks

Accessing jira-attachments will result in a 5xx #9111

mattkrick opened this issue Nov 2, 2023 · 5 comments · Fixed by #9278
Assignees
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@mattkrick
Copy link
Member

From Slack:
https://parabol.slack.com/archives/C4JAUUZ9P/p1698966704621919?thread_ts=1698858093.998069&cid=C4JAUUZ9P

response_sent_by_backend: mostly action.parabol.co/jira-attachements/HASHES urls. 1087 entries, see GCP logs here. Something must be not working with Jira. This status response_sent_by_backend means that the application is answering with 5XX and the LB is just passing the answer through. We should probably fix how we manage errors coming from JIRA to stop answering with 5XX here.
Latency for the jira-attachements isn't that high, most of them less than 200ms and some almost 1s
Also some POST calls to action.parabol.co/graphql, which have higher latency (over 10s).

AC

  • audit the handler and see why we don't always return a 200
  • if it's still unclear, gather some recent logs & see if we can repeat the request for a given hash
@mattkrick mattkrick added bug p2 Needs to be addressed on a reasonable timescale labels Nov 2, 2023
@rafaelromcar-parabol
Copy link
Contributor

This is a P2 but very important for us DevOps as it adds noise in our metrics and logs. It would be great to have it fixed asap.

@mwermuth
Copy link
Contributor

mwermuth commented Nov 7, 2023

Hey @mattkrick I saw you added this to the DevOps board. Will you be able to fix this?

@mwermuth mwermuth removed this from Bugs/Support Nov 7, 2023
@mattkrick
Copy link
Member Author

yep

@mattkrick mattkrick self-assigned this Dec 4, 2023
@mattkrick
Copy link
Member Author

Now that we have a healthy number of images imported from the server, I think we can standardize how they should be imported.

We have 3 images:

  • our logo, used in mattermost messages. what we want here is a URL that points to the instance's CDN so when the client opens up their mattermost, it loads from their CDN, which they have whitelisted
  • anonymous avatar, used in emails. needs to be a raster (another issue), but also needs to be available in the email (base64 inlining is another option, but our emails can get so big they get truncated)
  • jira image not found. we keep this on the webserver as a buffer. it'd be great to keep it local, but a one-time fetch is worth the simplicity vs. special casing it!

in dev mode, these 3 should end up in the /dev directory, which should get fetched from /static)

@mattkrick
Copy link
Member Author

mattkrick commented Jan 16, 2024

done back in Dec

edit-- nooope, still open, reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants