Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Library v2: update activity card UI #9112

Closed
3 tasks
nickoferrall opened this issue Nov 3, 2023 · 4 comments · Fixed by #9168
Closed
3 tasks

Activity Library v2: update activity card UI #9112

nickoferrall opened this issue Nov 3, 2023 · 4 comments · Fixed by #9168
Assignees

Comments

@nickoferrall
Copy link
Contributor

Figma designs: https://www.figma.com/file/PmE9A2ryODVzFPjZFJn7qi/Parabol-Activity-Library?type=design&node-id=1036-28426&mode=design&t=0hT1JdrobaDPvoKr-0

image

AC

  • Move template name below the activity card
  • Add the meeting type below the template name
  • Update the background colour on the activity cards
@nickoferrall
Copy link
Contributor Author

@enriquesanchez if you click on the "Retrospective" tab, would the meeting type "Retrospective" still show up under the template name?

@nickoferrall nickoferrall changed the title Activity library v2: update activity card UI Activity Library v2: update activity card UI Nov 3, 2023
@enriquesanchez
Copy link
Contributor

@nickoferrall I had some early iterations where I removed the meeting type if you had navigated into the category tab, or more recent ones like the Favorites view where there are category subsections.

I'm still on the fence about it, the type is a very important piece of info and I worry that despite the user navigating to a specific tab, it still won't be clear enough what they are looking at.

I think the safest thing to try is to keep it for category views, and we can test with the Favorites view if removing it has any negative effects.

How does that sound?

@nickoferrall nickoferrall self-assigned this Nov 7, 2023
@nickoferrall
Copy link
Contributor Author

Sounds good to me! It'll be easy to implement if we keep the meeting type in all the views too 👍

@nickoferrall
Copy link
Contributor Author

Hey @enriquesanchez, would you mind sending me the background image for the activity card? It looks similar the Perlin swirling lines that Figma offers, but I can't see the image in the Assets folder. I'm probably looking in the wrong place.

Also, for the meeting types, I'm currently showing: retrospective, feedback, poker, and standups. Premortem and post-morten, for example, would count as retrospective.

I'm mapping our internal meetingTypeEnum to these four categories:

  retrospective: 'retrospective',
  action: 'feedback',
  poker: 'estimation',
  teamPrompt: 'standup'

Let me know if you had something else in mind! 🙏

@nickoferrall nickoferrall moved this from 📋Todo to 👀Review in 🧁Product Squad Self Raise Nov 13, 2023
@nickoferrall nickoferrall moved this from 👀Review to 🚧Stuck in 🧁Product Squad Self Raise Nov 21, 2023
@nickoferrall nickoferrall moved this from 🚧Stuck to 👀Review in 🧁Product Squad Self Raise Nov 21, 2023
@github-project-automation github-project-automation bot moved this from 👀Review to ✅Done in 🧁Product Squad Self Raise Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

2 participants