Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org showing up multiple times after auto join #9229

Closed
1 task
nickoferrall opened this issue Nov 21, 2023 · 2 comments · Fixed by #9290
Closed
1 task

Org showing up multiple times after auto join #9229

nickoferrall opened this issue Nov 21, 2023 · 2 comments · Fixed by #9290
Assignees
@Dschoordsch
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@nickoferrall
Copy link
Contributor

@acressall shared the bug here: https://parabol.slack.com/archives/C042E8PGPD4/p1700530049859259

AC

  • Org only shows up once after auto joining multiple teams in the same org
@nickoferrall nickoferrall added the p2 Needs to be addressed on a reasonable timescale label Nov 21, 2023
@Dschoordsch Dschoordsch self-assigned this Dec 15, 2023
@Dschoordsch Dschoordsch moved this from 📋Todo to 🏗️In Progress in 🧁Product Squad Self Raise Dec 15, 2023
@Dschoordsch
Copy link
Contributor

acceptTeamInvitation must not be run in parallel because adjustUserCount creates a new OrganizationUser if they're not present. This results in duplicate OrganizationUser objects and thus the org and teams showing up multiple times.

@Dschoordsch Dschoordsch mentioned this issue Dec 18, 2023
Merged
10 tasks
@Dschoordsch Dschoordsch moved this from 🏗️In Progress to 🚧Stuck in 🧁Product Squad Self Raise Dec 18, 2023
@Dschoordsch
Copy link
Contributor

It's unclear why we always create a new OrganizationUser. Until that's answered, this is stuck.

@Dschoordsch Dschoordsch moved this from 🚧Stuck to 👀Review in 🧁Product Squad Self Raise Dec 19, 2023
@github-project-automation github-project-automation bot moved this from 👀Review to ✅Done in 🧁Product Squad Self Raise Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dschoordsch Dschoordsch

Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Bugs/Support
Status: Done
🧁Product Squad Self Raise
Status: ✅Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix duplicate organizations for teams with auto join ParabolInc/parabol
2 participants
@Dschoordsch @nickoferrall