Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedder doesn't dive deep into schema #9582

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

mattkrick
Copy link
Member

embedder was typechecking the entire server, which was really slow.
root cause was the embedder resolved some modules that depending on the type RootSchema but not the root schema itself.

So, by moving the type into its own declaration file with no imports, we shaved the number of resolved modules down by about half.

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick mattkrick merged commit 8cdd901 into master Apr 1, 2024
5 checks passed
@mattkrick mattkrick deleted the fix/types-embedder branch April 1, 2024 18:45
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant