Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ironbank GH action to copy ip-to-server-id script #9594

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dbumblis-parabol
Copy link
Contributor

@dbumblis-parabol dbumblis-parabol commented Apr 2, 2024

Description

The ironbank GH action does not copy the tools script to use the pod IP for server ID in the application image. This adds that script to the artifacts used for that process

Final checklist

  • [x ] I checked the code review guidelines
  • [x ] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [x ] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x ] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x ] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x ] I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [ x] PR title is human readable and could be used in changelog

@dbumblis-parabol dbumblis-parabol added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Apr 2, 2024
@dbumblis-parabol dbumblis-parabol merged commit 89aeea3 into master Apr 4, 2024
8 checks passed
@dbumblis-parabol dbumblis-parabol deleted the update-ironbank-action branch April 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant