Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: creating a threaded reply in the demo crashes #9672

Closed
Dschoordsch opened this issue Apr 25, 2024 · 3 comments · Fixed by #10262
Closed

Bug: creating a threaded reply in the demo crashes #9672

Dschoordsch opened this issue Apr 25, 2024 · 3 comments · Fixed by #10262
Assignees
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@Dschoordsch
Copy link
Contributor

Start the demo and advance to discussion. Reply to the first task created by the bot

https://parabol.sentry.io/issues/5254489567/?referrer=github_plugin

TypeError: Cannot read properties of undefined (reading '__typename')
  at map (./packages/client/components/ThreadedRepliesList.tsx:65:16)
  at Array.map (<anonymous>)
  at ThreadedRepliesList (./packages/client/components/ThreadedRepliesList.tsx:64:17)
  at Set.forEach (<anonymous>)
...
(30 additional frame(s) were not displayed)
@jordanh jordanh added bug p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users p2 Needs to be addressed on a reasonable timescale and removed p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users labels May 20, 2024
@jordanh jordanh added this to Product May 20, 2024
@github-project-automation github-project-automation bot moved this to To triage in Product May 20, 2024
@jordanh jordanh moved this from To triage to Ready in Product May 20, 2024
@jordanh
Copy link
Contributor

jordanh commented May 20, 2024

Prioritizing for triage this cycle

@Dschoordsch Dschoordsch self-assigned this Jun 12, 2024
@Dschoordsch
Copy link
Contributor Author

From tests it looks like #8094

@mattkrick
Copy link
Member

Confirmed, this is broken using relay v14.1.0.
Upgrading to relay v18 has fixed this problem, and it does not require upgrading react to v18.
I need to do more QA before upgrading to v18 since there's a lot of breaking changes between v14 & v18.
My suspicion is that relay wasn't using react's scheduler, so react could render a child component before rendering its parent. See facebook/relay#3514 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants