Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedder graceful shutdown #9677

Closed
rafaelromcar-parabol opened this issue Apr 29, 2024 · 1 comment
Closed

Embedder graceful shutdown #9677

rafaelromcar-parabol opened this issue Apr 29, 2024 · 1 comment
Assignees

Comments

@rafaelromcar-parabol
Copy link
Contributor

Issue - Enhancement

Today, when the Embedder receives the SIGTERM signal (for example, when Kubernetes wants to shutdown a pod) it just keeps processing jobs until it receives the SIGKILL and abruptly stops. According to the code, it should just kill itself when it receives the SIGTERM, but it does not act like it.

Proposal:

  • Add a message when the Embedder receives the SIGTERM signa.
  • Make the Embedder stop pulling new jobs to process.
  • Add a message when all jobs are either processed or timed out and the Embedder stops and exists.

Acceptance Criteria (optional)

The Embedder receives the SIGTERM signal and notifies, stops polling jobs from the queue, wait until the jobs it was processing end, and notifies and exists with 0.

Estimated effort: X points (see CONTRIBUTING.md)

@github-project-automation github-project-automation bot moved this to To triage in Product Apr 29, 2024
@Dschoordsch Dschoordsch self-assigned this Apr 29, 2024
@Dschoordsch Dschoordsch moved this from To triage to In review in Product May 2, 2024
@Dschoordsch
Copy link
Contributor

Solved by this PR #9693

@github-project-automation github-project-automation bot moved this from In review to Done in Product May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants