chore: remove discussion prompt from summary #9711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
commented
May 3, 2024
| const hasMoreThanOneReflection = | ||
| (reflectionGroups?.length && reflectionGroups.length > 1) || | ||
| reflectionGroups?.some((group) => group.reflections.length > 1) | ||
| if (!hasMoreThanOneReflection || organization.featureFlags.noAISummary) return null |
There was a problem hiding this comment.
If there's more than one reflection, we'll always create the meeting summary unless noAISummary is true, so we don't need to check if there's a discussion summary or reflection group summary (which is now removed anyway)
2 tasks
Dschoordsch
requested changes
May 7, 2024
| const hasDiscussionSummary = !!stages?.some((stage) => stage.discussion?.summary) | ||
| const hasOpenAISummary = hasTopicSummary || hasDiscussionSummary | ||
| const hasMoreThanOneReflection = reflections.length > 1 | ||
| const hasOpenAISummary = hasMoreThanOneReflection || !organization.featureFlags.noAISummary |
There was a problem hiding this comment.
-1 this should be &&, shouldn't it?
| ) | ||
| const [fullSummary, fullQuestion] = await Promise.all([ | ||
| manager.getSummary(reflectionTextByGroupId), | ||
| const [fullQuestion] = await Promise.all([ |
There was a problem hiding this comment.
-1 No need to wrap a single call in Promise.all([...])
Dschoordsch
approved these changes
May 8, 2024
Base automatically changed from
chore/8858/remove-ai-summary-from-thread
to
master
May 8, 2024 10:47
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9710
Demo: https://www.loom.com/share/728f893c2e054fbbad82f849e89ffeaa
The AI Summary for the reflection group is no longer being used but I don't want to remove it now as it looks like we're migrating that table from RethinkDB to PG. I've created an issue: #9712
To test