-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the issue where a successful upgrade won't refresh the billing page #9740
Conversation
commitLocalUpdate(atmosphere, (store) => { | ||
const organization = store.get(orgId) | ||
if (!organization) return | ||
organization.setValue('team', 'billingTier') | ||
organization.setValue('team', 'tier') | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 let's put this logic in the upgradeToTeamTierSuccessUpdater
where we also open the drawer and show the confetti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's missing the 2 topmost sections ("Invoices" and "Credit card") after the upgrade without a manual refresh, but it's already an improvement to the state before.
The invoices section is a bit tricky: we need to wait for Stripe to finalize the paid invoice & create the upcoming invoice to have the data to populate that view but those happen a little bit later than the payment success. To give the customer a faster turnaround & an indicator they have successfully upgraded, I think this is fine for now. |
Description
Fixes #9737
Demo
Stripe webhooks are slow locally. Please be patient while viewing this GIF😂:
Testing scenarios
team
team
tierBrew a cup of coffee and waitFinal checklist