feat: saml upload #9750
Merged
feat: saml upload #9750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <matt.krick@gmail.com>
mattkrick
commented
May 10, 2024
| @@ -61,7 +63,7 @@ const permissionMap: PermissionMap<Resolvers> = { | |||
| SAMLIdP: rateLimit({perMinute: 120, perHour: 3600}) | |||
| }, | |||
| Organization: { | |||
| saml: and(isViewerBillingLeaderSource, isOrgTierSource('enterprise')) | |||
| saml: and(isViewerBillingLeader('source.id'), isOrgTier('source.id', 'enterprise')) | |||
There was a problem hiding this comment.
curious on your thoughts about this new pattern.
I want to reuse rules as much as I can. For example, this rule requires an orgId to determine if the viewer is on the org. That orgId may exist in an arg, or in the source, and it could have any name. I think a dot notation path is the cleanest way to do this, but wonder what you think?
There was a problem hiding this comment.
I like it! Not having type safety is my main concern, but that's still probably safer that accidentally mixing isOrgTierSource for isOrgTier
nickoferrall
approved these changes
May 20, 2024
| @@ -61,7 +63,7 @@ const permissionMap: PermissionMap<Resolvers> = { | |||
| SAMLIdP: rateLimit({perMinute: 120, perHour: 3600}) | |||
| }, | |||
| Organization: { | |||
| saml: and(isViewerBillingLeaderSource, isOrgTierSource('enterprise')) | |||
| saml: and(isViewerBillingLeader('source.id'), isOrgTier('source.id', 'enterprise')) | |||
There was a problem hiding this comment.
I like it! Not having type safety is my main concern, but that's still probably safer that accidentally mixing isOrgTierSource for isOrgTier
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #9254
Supports uploading an XML file, which can then be used for the metadata URL
Demo
https://www.loom.com/share/23e34f4943ca4650803c9faad05bc488?sid=9d52a92c-093b-4b88-8bc3-8f37c31db1ca