Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Trace RRule #9756

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: Trace RRule #9756

merged 1 commit into from
May 15, 2024

Conversation

Dschoordsch
Copy link
Contributor

There is a 5s gap in the traces 🔒 from fetching all the meeting series' last meetings and starting the new ones. In this time we only do some RRule parsing and calculations. Let's trace these.

Description

Fixes/Partially Fixes #[issue number]
[Please include a summary of the changes and the related issue]

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

There is a 5s gap in the traces from fetching all the meeting series'
last meetings and starting the new ones. In this time we only do some
RRule parsing and calculations. Let's trace these.
@Dschoordsch
Copy link
Contributor Author

Slowness in RRule would also explain the flaky recurrence test

@Dschoordsch Dschoordsch merged commit 341772a into master May 15, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the chore/traceRRule branch May 15, 2024 18:14
@github-actions github-actions bot mentioned this pull request May 21, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant