Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send correct websocket status code #9760

Merged
merged 1 commit into from
May 21, 2024

Conversation

Dschoordsch
Copy link
Contributor

Fixes #8370

Safari will ignore the reason if the code is not in the valid range.

Testing scenarios

  • Log in with safari
  • update server secret and restart server
  • do not see reconnect errors on the server every second
    12:31:32 1|Socket Server    | Trace: SEND TO SENTRY invalid signature {"jwt":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJsb2NhbHx3TklJVEZySW1BIiwidG1zIjpbIndOSUlVNHFwT2giXSwiaWF0IjoxNzE1MzI3Mjg1LCJhdWQiOiJhY3Rpb24iLCJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjMwMDAvIiwiZXhwIjoxNzE3OTE5Mjg1LCJyb2wiOm51bGx9.ORiRoaQSXBl3C9jgAZ8NatS9YLaai2NLbu2YiDIOdCc"} undefined
    12:31:32 1|Socket Server    |     at sendToSentry (/Volumes/User/parabol/dev/web.js:85538:11)
    12:31:32 1|Socket Server    |     at getVerifiedAuthToken (/Volumes/User/parabol/dev/web.js:84436:28)
    12:31:32 1|Socket Server    |     at getQueryToken (/Volumes/User/parabol/dev/web.js:84081:41)
    12:31:32 1|Socket Server    |     at handleUpgrade (/Volumes/User/parabol/dev/web.js:78311:45)
    12:31:32 1|Socket Server    |     at topLevelDomainCallback (node:domain:160:15)
    12:31:32 1|Socket Server    |     at callbackTrampoline (node:internal/async_hooks:128:24)
    12:31:33 1|Socket Server    | Trace: SEND TO SENTRY invalid signature {"jwt":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJsb2NhbHx3TklJVEZySW1BIiwidG1zIjpbIndOSUlVNHFwT2giXSwiaWF0IjoxNzE1MzI3Mjg1LCJhdWQiOiJhY3Rpb24iLCJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjMwMDAvIiwiZXhwIjoxNzE3OTE5Mjg1LCJyb2wiOm51bGx9.ORiRoaQSXBl3C9jgAZ8NatS9YLaai2NLbu2YiDIOdCc"} undefined
    

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Safari will ignore the reason if the code is not in the valid range.
@Dschoordsch Dschoordsch merged commit ca20d75 into master May 21, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/8370/sendCorrectWebsocketStatus branch May 21, 2024 11:16
@github-actions github-actions bot mentioned this pull request May 21, 2024
24 tasks
@mattkrick
Copy link
Member

wow, great find! also, thanks for bumping down the package to v3.0.1.
Having a broken latest version (v3.0.2) was lazy & dangerous of me to do, so i created v3.0.3, which is the same as v3.0.1, bump now we won't run that risk again if it gets upgraded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelayNetwork: No data returned for operation TeamContainerQuery, got error(s):
2 participants