Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure dashboard sidebar animates smoothly #9865

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Jun 25, 2024

Fix issues @mattkrick shared here

Loom demo: https://www.loom.com/share/7ec1e767949b4c7fbee1fff3afe2ed09

This PR ensures that:

  • Opening and closing the sidebar animates smoothly
  • If an org has no teams, there's no divider
  • The settings menu doesn't conflict with the text on the task cards

Things to note:

  • I reduced the width of the Add Meeting button slightly. It's still wider than prod, but narrower than it was.
  • The three-line long team name is an edge case. A team name with the max characters allowed is usually 2 lines, but if the characters are particularly wide, e.g. 3 instead of i, it can take up three lines. I'm hesitant about changing the padding without a review from @ackernaut, so I'd prefer to merge this.
  • I also like your point about removing the menu. I think Terry could see how it feels in production and decide whether to keep/remove it.

@mattkrick
Copy link
Member

awesome! yeah, team name length is an edge case for sure, i'll get it on staging & give it a go!

@mattkrick mattkrick changed the base branch from release/v7.37.0 to master June 25, 2024 15:45
@mattkrick mattkrick merged commit 73cdb7c into master Jun 25, 2024
8 checks passed
@mattkrick mattkrick deleted the fix/left-nav-issues branch June 25, 2024 15:46
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants