feat: Add filter views to save frequently used filters in data browser #2404

dblythy · 2023-03-11T02:02:39Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Adds ability to save filters

Closes: #2041

Approach

Saves predefined filters in localstorage with similar logic to ColumnPreferences, only under a new class ClassPreferences. This data might be used for future class specific features

TODOs before merging

Add tests

parse-github-assistant · 2023-03-11T02:02:41Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-03-11T02:02:44Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

dblythy · 2023-03-11T02:05:05Z

Some of the changes are due to local version of the prettier - do we have a code linting / styler?

mtrezza · 2023-03-11T02:08:48Z

You mean whether we have a lint script to auto-correct ?

…oard into filter-views

dblythy · 2023-03-11T02:09:43Z

Yep 😊

mtrezza · 2023-03-11T02:10:57Z

It seems to be missing here, feel free to just throw it in with this PR, maybe same names as with Parse Server:

"lint": "flow && eslint --cache ./",
"lint-fix": "eslint --fix --cache ./",

uffizzi-cloud · 2023-03-11T02:12:02Z

Uffizzi Ephemeral Environment `deployment-18701`

⌚ Updated Mar 11, 2023, 02:10 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2404

📄 View Application Logs etc.

What is Uffizzi? Learn more

dblythy · 2023-03-11T02:14:52Z

mov.mov

Demo of the PR, i'll try do some work around making sure the sidebar shows active on the filtered tab

mtrezza · 2023-03-11T02:14:54Z

This is interesting with Uffizzi, I think to preview this we'd have to deploy a config file and later remove it before merging the PR. That woudn't be ideal because we may forget to remove and release it.

dblythy · 2023-03-11T02:24:34Z

I think Ufuzzi will be fine for this because I've done all the filter saving in local storage (similar to how column preferences are managed)

src/lib/ClassPreferences.js

src/components/BrowserFilter/BrowserFilter.react.js

mtrezza

For the filter dialog, could you:

Move the "Save" button the very left? It's a button that is used the least (once to save, then not anymore).

For the save dialog, could you:

Remove buttons "Clear all", "Add filter", "Apply filter"
Rename "Confim" to "Save"
Add a "Cancel" or "Back" button on the left

src/components/BrowserFilter/BrowserFilter.react.js

mtrezza · 2023-03-11T02:53:15Z

This PR seems to mix #2041 and #2403. #2403 (comment) may be important to consider here. We may need to find a way to differentiate between "saving a filter pattern" and "saving a filter view" in the UI.

Maybe a solution is to add a "more" button "..." to the very left that opens a dropdown where one can choose:

Download filter definition // to copy/paste into config file
Upload filter definition // same as loading a filter from config file, but allows to upload only the definition
Save filter view locally // to save locally, i.e. ephemeral storage as it does now

Instead of the Download filter definition and Upload filter definition a button to toggle between an editable raw JSON definition of the current filter setting could be an alternative. So one can toggle from the UI view to the JSON view and just copy the definition, or paste it, or just edit it. Not sure how difficult that would be to implement, but it would make the file up/download logic unnecessary.

mtrezza · 2023-03-11T02:58:29Z

I find this to be a good UI solution, much nicer than the arrow on the left

dblythy · 2023-03-12T00:27:12Z

Perhaps we can add a settings page that allows exporting of certain configurations to be defined later on Parse Dashboard? An example is the ColumnPreferences feature, it's quite difficult to extract that at the moment

Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com> Signed-off-by: Daniel <daniel-blyth@live.com.au>

…oard into filter-views

mtrezza · 2023-03-12T11:27:14Z

I think that's an interesting idea. Could be a good workout until we find a concept for storing dashboard settings in the cloud.

mtrezza

There's a text alignment issue - the longer the filter name, the further left the leading edge of the text:

mtrezza

This PR also reveals a semantic issue - a filter condition is called "filter" as well. To fix this let's just simplify the buttons:

"Clear al" to "Clear"
"Add filter" to "Add"
"Save filters" to "Save"
"Apply filter" to "Apply"

It's a simple dialog and probably easy to infer what they mean.

mtrezza

What should we call this filter?

mtrezza · 2023-05-27T12:59:20Z

Before we get more conflicts, @dblythy could you take a look and try to get this ready for merge?

Signed-off-by: Daniel <daniel-blyth@live.com.au>

dblythy · 2023-06-09T02:36:54Z

I've done some work making the highlight and selection of the filter cleaner:

dblythy · 2023-06-09T02:57:53Z

Uffuzi hasn't updated to the latest commit, let's see if reopening helps...

uffizzi-cloud · 2023-06-09T03:07:10Z

Uffizzi Ephemeral Environment `deployment-28018`

⌚ Updated Jun 09, 2023, 02:58 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2404

📄 View Application Logs etc.

What is Uffizzi? Learn more

mtrezza

Looks good, and works in preview env; what a fine feature!

# [5.2.0-alpha.12](5.2.0-alpha.11...5.2.0-alpha.12) (2023-06-09) ### Features * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))

parseplatformorg · 2023-06-09T12:10:32Z

🎉 This change has been released in version 5.2.0-alpha.12

# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))

parseplatformorg · 2023-06-10T14:03:47Z

🎉 This change has been released in version 5.2.0-beta.2

# [5.2.0](5.1.0...5.2.0) (2023-09-15) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) * Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839)) * Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b)) * Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))

parseplatformorg · 2023-09-15T14:12:15Z

🎉 This change has been released in version 5.2.0

* release: (41 commits) chore(release): 5.2.0 [skip ci] release chore(release): 5.2.0-beta.2 [skip ci] empty commit chore(release): 5.2.0-alpha.14 [skip ci] fix: Hitting backspace key in data browser crashes dashboard (parse-community#2456) chore(release): 5.2.0-alpha.13 [skip ci] feat: Add export of saved data browser filters via `classPreference` settings (parse-community#2455) chore(release): 5.2.0-alpha.12 [skip ci] feat: Add filter views to save frequently used filters in data browser (parse-community#2404) chore(release): 5.2.0-alpha.11 [skip ci] fix: Scroll position is preserved when re-opening the same class in data browser via navigation bar (parse-community#2445) chore(release): 5.2.0-alpha.10 [skip ci] fix: Option missing for Parse Config parameter to require master key (parse-community#2440) chore(release): 5.2.0-alpha.9 [skip ci] fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers (parse-community#2416) chore(release): 5.2.0-alpha.8 [skip ci] fix: Cannot navigate to nested relation field in data browser (parse-community#2420) chore(release): 5.2.0-alpha.7 [skip ci] fix: File uploading status not updating in data browser (parse-community#2422) ... # Conflicts: # package-lock.json

feat: create predefined filters

9742e3e

parse-github-assistant bot changed the title ~~feat: create predefined filters~~ feat: Create predefined filters Mar 11, 2023

refactor

eeb4b47

Merge branch 'alpha' into filter-views

9cb8eb4

dblythy added 2 commits March 11, 2023 13:09

lint

6059018

Merge branch 'filter-views' of https://github.com/dblythy/parse-dashb…

2d55ece

…oard into filter-views

mtrezza mentioned this pull request Mar 11, 2023

Add PR deployment preview #2374

Open

3 tasks

refactor

a0712fe

mtrezza reviewed Mar 11, 2023

View reviewed changes

src/lib/ClassPreferences.js Outdated Show resolved Hide resolved

src/lib/ClassPreferences.js Show resolved Hide resolved

mtrezza requested changes Mar 11, 2023

View reviewed changes

src/components/BrowserFilter/BrowserFilter.react.js Outdated Show resolved Hide resolved

mtrezza requested changes Mar 11, 2023

View reviewed changes

src/components/BrowserFilter/BrowserFilter.react.js Outdated Show resolved Hide resolved

mtrezza requested changes Mar 11, 2023

View reviewed changes

src/components/BrowserFilter/BrowserFilter.react.js Outdated Show resolved Hide resolved

mtrezza changed the title ~~feat: Create predefined filters~~ feat: Add filter views Mar 11, 2023

dblythy and others added 4 commits March 12, 2023 11:39

Update src/components/BrowserFilter/BrowserFilter.react.js

3f990d1

Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com> Signed-off-by: Daniel <daniel-blyth@live.com.au>

wip

37e35f6

Merge branch 'filter-views' of https://github.com/dblythy/parse-dashb…

7cd5ee1

…oard into filter-views

Update BrowserFilter.react.js

1732167

dblythy requested a review from a team March 29, 2023 02:15

Merge branch 'alpha' into filter-views

1e28ab3

mtrezza requested changes May 21, 2023

View reviewed changes

dblythy added 2 commits June 9, 2023 11:36

Merge branch 'alpha' into filter-views

3ffa1fe

Signed-off-by: Daniel <daniel-blyth@live.com.au>

improve sidebar

52ac136

dblythy closed this Jun 9, 2023

dblythy reopened this Jun 9, 2023

dblythy requested a review from mtrezza June 9, 2023 03:06

mtrezza approved these changes Jun 9, 2023

View reviewed changes

mtrezza changed the title ~~feat: Add filter views~~ feat: Add filter views to save frequently used filters in data browser Jun 9, 2023

mtrezza merged commit a9ec3a9 into parse-community:alpha Jun 9, 2023

parseplatformorg added the state:released-alpha Released as alpha version label Jun 9, 2023

dblythy deleted the filter-views branch June 9, 2023 12:56

parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023

mtrezza mentioned this pull request Jun 11, 2023

Add filter patterns #2403

Closed

3 tasks

parseplatformorg added the state:released Released as stable version label Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add filter views to save frequently used filters in data browser #2404

feat: Add filter views to save frequently used filters in data browser #2404

dblythy commented Mar 11, 2023

parse-github-assistant bot commented Mar 11, 2023

parse-github-assistant bot commented Mar 11, 2023 •

edited

Loading

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023

uffizzi-cloud bot commented Mar 11, 2023

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023 •

edited

Loading

dblythy commented Mar 11, 2023

mtrezza left a comment •

edited

Loading

mtrezza commented Mar 11, 2023 •

edited

Loading

mtrezza commented Mar 11, 2023

dblythy commented Mar 12, 2023

mtrezza commented Mar 12, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza left a comment

mtrezza commented May 27, 2023

dblythy commented Jun 9, 2023 •

edited

Loading

dblythy commented Jun 9, 2023

uffizzi-cloud bot commented Jun 9, 2023

mtrezza left a comment

parseplatformorg commented Jun 9, 2023

parseplatformorg commented Jun 10, 2023

parseplatformorg commented Sep 15, 2023

feat: Add filter views to save frequently used filters in data browser #2404

feat: Add filter views to save frequently used filters in data browser #2404

Conversation

dblythy commented Mar 11, 2023

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Mar 11, 2023

parse-github-assistant bot commented Mar 11, 2023 • edited Loading

Thanks for opening this pull request!

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023

uffizzi-cloud bot commented Mar 11, 2023

Uffizzi Ephemeral Environment deployment-18701

dblythy commented Mar 11, 2023

mtrezza commented Mar 11, 2023 • edited Loading

dblythy commented Mar 11, 2023

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza commented Mar 11, 2023 • edited Loading

mtrezza commented Mar 11, 2023

dblythy commented Mar 12, 2023

mtrezza commented Mar 12, 2023 • edited Loading

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza left a comment

Choose a reason for hiding this comment

mtrezza commented May 27, 2023

dblythy commented Jun 9, 2023 • edited Loading

dblythy commented Jun 9, 2023

uffizzi-cloud bot commented Jun 9, 2023

Uffizzi Ephemeral Environment deployment-28018

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented Jun 9, 2023

parseplatformorg commented Jun 10, 2023

parseplatformorg commented Sep 15, 2023

parse-github-assistant bot commented Mar 11, 2023 •

edited

Loading

Uffizzi Ephemeral Environment `deployment-18701`

mtrezza commented Mar 11, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Mar 11, 2023 •

edited

Loading

mtrezza commented Mar 12, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza left a comment •

edited

Loading

dblythy commented Jun 9, 2023 •

edited

Loading

Uffizzi Ephemeral Environment `deployment-28018`