Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly sets installationId on creating session with 3rd party auth #1110

Merged
merged 2 commits into from
Mar 21, 2016
Merged

Properly sets installationId on creating session with 3rd party auth #1110

merged 2 commits into from
Mar 21, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1097

@codecov-io
Copy link

Current coverage is 91.92%

Merging #1110 into master will increase coverage by +0.01% as of 24f0fff

@@            master   #1110   diff @@
======================================
  Files           91      91       
  Stmts         5736    5736       
  Branches      1043    1043       
  Methods          0       0       
======================================
+ Hit           5272    5273     +1
  Partial         11      11       
+ Missed         453     452     -1

Review entire Coverage Diff as of 24f0fff

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart
flovilmart reviewed Mar 20, 2016
View reviewed changes
spec/ParseUser.spec.js
@@ -1784,6 +1784,34 @@ describe('Parse.User testing', () => {
var b = JSON.parse(body);
expect(typeof b.sessionToken).toEqual('string');
expect(typeof b.createdWith).toEqual('object');
expect(b.createdWith.action).toEqual('signup');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's now signup to match original parse.com behaviour as described here

@flovilmart flovilmart force-pushed the flovilmart.missingSessionInstallationId branch from 7d736de to a31baa4 Compare March 20, 2016 19:58
flovilmart added a commit that referenced this pull request Mar 21, 2016
@flovilmart
Merge pull request #1110 from ParsePlatform/flovilmart.missingSession…
fb57d91 
…InstallationId

Properly sets installationId on creating session with 3rd party auth
@flovilmart flovilmart merged commit fb57d91 into master Mar 21, 2016
@flovilmart flovilmart deleted the flovilmart.missingSessionInstallationId branch March 21, 2016 12:21
This was referenced Jul 9, 2020
Open
Open
This was referenced Aug 16, 2020
Open
Open
This was referenced Aug 27, 2020
Open
Open
@skmezanul skmezanul mentioned this pull request Feb 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installationId is not set in _Session object when using 3rd party auth and signUp
4 participants
@flovilmart @codecov-io @facebook-github-bot @gfosco