-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves Files adapters to external packages #1172
Conversation
00f2aac
to
1e45ac7
Compare
@flovilmart updated the pull request. |
- Something weird is happening here, instanceof is not giving the right value
@flovilmart updated the pull request. |
Current coverage is
|
* | ||
* | ||
* | ||
* | ||
* @param config the current config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comments
Looks awesome to me but I guess because of removal of |
It definitely is, but looks like a good change. We would need to increment a minor version for the next release, hence breaking changes. I wish we moved GridStoreAdapter as well... |
Lets add some info about the breaking change and how to deal with it in the changelog or release notes or something, then merge. |
@flovilmart updated the pull request. |
No description provided.