Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1302 #1314

Merged
merged 2 commits into from
Apr 1, 2016
Merged

Fixes issue #1302 #1314

merged 2 commits into from
Apr 1, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1302

When querying with include on an array of pointers, filter out the nulls and undefined to keep it going AND to have properly set result arrays sent to the client

- when including elements from an array of pointers, filters unaccessible/missing objects
@flovilmart flovilmart changed the title Flovilmart.issue1302 Fixes issue #1302 Apr 1, 2016
@codecov-io
Copy link

Current coverage is 93.05%

Merging #1314 into master will not affect coverage as of b718cda

@@            master   #1314   diff @@
======================================
  Files           84      84       
  Stmts         5301    5302     +1
  Branches       969     970     +1
  Methods          0       0       
======================================
+ Hit           4933    4934     +1
  Partial         11      11       
  Missed         357     357       

Review entire Coverage Diff as of b718cda

Powered by Codecov. Updated on successful CI builds.

@drew-gross drew-gross merged commit 57156cf into master Apr 1, 2016
@drew-gross drew-gross deleted the flovilmart.issue1302 branch April 1, 2016 02:00
@drew-gross
Copy link
Contributor

Nice. We are coming across edgier and edgier edge cases now. I think that means we are starting to become stable.

@flovilmart
Copy link
Contributor Author

Yeah and those are relatively trivial and quick fixes. The longest is to write the test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include={field.2ndLevel} of array of pointers which point to not existing objects returns error.
4 participants