Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Huge performance improvement on roles queries #1383

Merged
merged 1 commit into from
Apr 6, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1380

@codecov-io
Copy link

Current coverage is 92.83%

Merging #1383 into master will decrease coverage by -0.01% as of e6fa589

@@            master   #1383   diff @@
======================================
  Files           86      86       
  Stmts         5447    5443     -4
  Branches      1004    1005     +1
  Methods          0       0       
======================================
- Hit           5057    5053     -4
  Partial         10      10       
  Missed         380     380       

Review entire Coverage Diff as of e6fa589

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart force-pushed the improve-role-loading branch from dc8b15b to e6fa589 Compare April 5, 2016 23:49
@flovilmart flovilmart changed the title Huge performance improvement on roles queries WIP: Huge performance improvement on roles queries Apr 5, 2016
@blacha
Copy link
Contributor

blacha commented Apr 6, 2016

This is a massive improvement, this takes my application from 235 Role queries per request down to 14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT request causes server to stop responding and memory use increases when user is a part of many Roles
4 participants