Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for --verbose and verbose option when running ParseServer #1414

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Adds support for --verbose and verbose option when running ParseServer #1414

merged 1 commit into from
Apr 7, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 92.76%

Merging #1414 into master will not affect coverage as of f8ebcc9

@@            master   #1414   diff @@
======================================
  Files           86      86       
  Stmts         5433    5432     -1
  Branches      1004    1003     -1
  Methods          0       0       
======================================
- Hit           5040    5039     -1
  Partial         10      10       
  Missed         383     383

Review entire Coverage Diff as of f8ebcc9

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart
Copy link
Contributor Author

I don't do any check on the validity of the specified log level.
By default setting --verbose or verbose = true, sets the logLevel to silly (we don't use anything above verbose for now)

@drew-gross
Copy link
Contributor

Can you split this into 2 PRs? I think the logging stuff makes sense, but the settings endpoint is a new API that probably deserves more discussion.

@flovilmart
Copy link
Contributor Author

yep

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart
Copy link
Contributor Author

waiting for travis then merging

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart merged commit cedac3f into master Apr 7, 2016
@flovilmart flovilmart deleted the verbose-option branch April 7, 2016 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drew-gross drew-gross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovilmart @codecov-io @facebook-github-bot @drew-gross