Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store collection prefix in mongo adapter, and clean up adapter interface #1472

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

drew-gross
Copy link
Contributor

This removed a couple apis that were either unused or could never have possibly worked. It also stores the collection prefix in the mongo adapter. Actually using that prefix will come in another PR.

@codecov-io
Copy link

Current coverage is 92.87%

Merging #1472 into master will increase coverage by +0.06% as of d960acb

@@            master   #1472   diff @@
======================================
  Files           87      87       
  Stmts         5501    5499     -2
  Branches      1016    1017     +1
  Methods          0       0       
======================================
+ Hit           5106    5107     +1
  Partial         10      10       
+ Missed         385     382     -3

Review entire Coverage Diff as of d960acb

Powered by Codecov. Updated on successful CI builds.

@drew-gross drew-gross force-pushed the move-collectionPrefix branch from df98783 to 94fefb5 Compare April 13, 2016 04:50
@facebook-github-bot
Copy link

@drew-gross updated the pull request.

@@ -68,17 +63,20 @@ function getDatabaseConnection(appId: string, collectionPrefix: string) {

var dbURI = (appDatabaseURIs[appId] ? appDatabaseURIs[appId] : databaseURI);

let storageAdapter = new adapter(dbURI, appDatabaseOptions[appId]);
let storageAdapter = new MongoStorageAdapter({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cleaner!

@flovilmart flovilmart merged commit 3fb3ce1 into parse-community:master Apr 13, 2016
drew-gross added a commit to drew-gross/parse-server that referenced this pull request May 10, 2016
drew-gross added a commit that referenced this pull request May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants