Adds limit = 0 as a valid parameter for queries #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijiakiyama
changed the title
Current coverage is
|
| @@ -9,12 +9,13 @@ | |||
| }, | |||
| "files": [ | |||
| "bin/", | |||
| "lib/", | |||
| "src/", | |||
There was a problem hiding this comment.
Sorry about that. I was expecting to merge it on our fork first. My mistake. This change was not supposed to be here.
|
@seijiakiyama updated the pull request. |
|
Sweet, this should fix some issues we've been seeing in the dashboard as well. Can you rebase and resolve conflicts? Then we can merge. |
| if (this.className == '_User') { | ||
| for (var result of results) { | ||
| delete result.password; | ||
| if (this.findOptions.limit !== 0) { |
There was a problem hiding this comment.
Id's suggest to improve readability:
if (this.findOptions.limit === 0) {
this.response = {results: []};
return Promise.resolve();
}
// original code
|
@seijiakiyama updated the pull request. |
This was referenced Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.