Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply credential stripping to all untransforms for _User #1498

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Apply credential stripping to all untransforms for _User #1498

merged 1 commit into from
Apr 14, 2016

Conversation

TylerBrock
Copy link
Contributor

@TylerBrock TylerBrock commented Apr 14, 2016 •
edited
Loading

The tests describe what is going on. Basically we also want to strip sessionToken and auth data when isMaster is used. Fixes #1482

@TylerBrock TylerBrock force-pushed the isMaster-sessionToken-strip branch from 13cdbd7 to f16b971 Compare April 14, 2016 21:38
@facebook-github-bot
Copy link

@TylerBrock updated the pull request.

@codecov-io
Copy link

Current coverage is 92.79%

Merging #1498 into master will decrease coverage by -0.09% as of 7b2c0b0

@@            master   #1498   diff @@
======================================
  Files           87      87       
  Stmts         5496    5496       
  Branches      1017    1017       
  Methods          0       0       
======================================
- Hit           5105    5100     -5
  Partial         10      10       
- Missed         381     386     +5

Review entire Coverage Diff as of 7b2c0b0

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor

Good catch! Looks good to me.

@drew-gross drew-gross merged commit d57e384 into parse-community:master Apr 14, 2016
@steven-supersolid steven-supersolid mentioned this pull request Apr 20, 2016
Closed
steven-supersolid added a commit to supersolid/parse-server that referenced this pull request Apr 20, 2016
@steven-supersolid
Apply credential stripping to all untransforms for _User (parse-commu…
c1bc833 
…nity#1498) (reverted from commit d57e384)
steven-supersolid added a commit to supersolid/parse-server that referenced this pull request Apr 20, 2016
@steven-supersolid
release 2.2.7 bugfix revert parse-community#1498
c548d8c
@lenew lenew mentioned this pull request Apr 25, 2016
Closed
@skmezanul skmezanul mentioned this pull request Nov 24, 2023
Open
@skmezanul skmezanul mentioned this pull request Feb 18, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Feb 18, 2024
Closed
@kiarza2543 kiarza2543 mentioned this pull request Feb 19, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Feb 19, 2024
Closed
@parseplatformorg parseplatformorg mentioned this pull request Apr 5, 2024
Closed
@kiarza2543 kiarza2543 mentioned this pull request Apr 6, 2024
Merged
@skmezanul skmezanul mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TylerBrock @facebook-github-bot @codecov-io @drew-gross