Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test empty authData block on login for #413 #863

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Mar 6, 2016

extends on #679 and tests login too.

@codecov-io
Copy link

Current coverage is 91.66%

Merging #863 into master will decrease coverage by -0.02% as of 1c02854

@@            master    #863   diff @@
======================================
  Files           71      71       
  Stmts         4102    4102       
  Branches       845     845       
  Methods          0       0       
======================================
- Hit           3761    3760     -1
  Partial         10      10       
- Missed         331     332     +1

Review entire Coverage Diff as of 1c02854

Powered by Codecov. Updated on successful CI builds.

request.get(requestOptions, (error, response, body) => {
expect(error).toBe(null);
let b = JSON.parse(body);
expect(typeof b['sessionToken']).toEqual('string');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an expect for The session token length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as error was null, we're in the clear here. Checking sessionToken exists was just a sanity check, and we don't seem to do a length check anywhere in ParseUser.spec.js.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright!

gfosco added a commit that referenced this pull request Mar 6, 2016
Test empty authData block on login for #413
@gfosco gfosco merged commit e92ee7e into master Mar 6, 2016
@gfosco gfosco deleted the fosco.authData2 branch March 6, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants