Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup PushController/PushRouter, remove raw mongo collection access. #903

Merged
merged 4 commits into from
Mar 8, 2016
Merged

Cleanup PushController/PushRouter, remove raw mongo collection access. #903

merged 4 commits into from
Mar 8, 2016

Conversation

nlutsenko
Copy link
Contributor

image

@nlutsenko nlutsenko assigned nlutsenko and unassigned drew-gross Mar 7, 2016
flovilmart
flovilmart reviewed Mar 8, 2016
View reviewed changes
src/Controllers/DatabaseController.js
@@ -35,7 +35,7 @@ DatabaseController.prototype.collection = function(className) {
throw new Parse.Error(Parse.Error.INVALID_CLASS_NAME,
'invalid className: ' + className);
}
return this.rawCollection(className);
return this.adapter.collection(this.collectionPrefix + className);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flovilmart
Copy link
Contributor

LGTM

@flovilmart flovilmart mentioned this pull request Mar 8, 2016
Merged
@codecov-io
Copy link

Current coverage is 91.72%

Merging #903 into master will increase coverage by +0.01% as of c3f0550

@@            master    #903   diff @@
======================================
  Files           71      71       
  Stmts         4104    4097     -7
  Branches       850     847     -3
  Methods          0       0       
======================================
- Hit           3764    3758     -6
  Partial         10      10       
+ Missed         330     329     -1

Review entire Coverage Diff as of c3f0550

Powered by Codecov. Updated on successful CI builds.

@nlutsenko nlutsenko assigned flovilmart and unassigned nlutsenko Mar 8, 2016
@facebook-github-bot
Copy link

@nlutsenko updated the pull request.

@facebook-github-bot
Copy link

@nlutsenko updated the pull request.

flovilmart added a commit that referenced this pull request Mar 8, 2016
@flovilmart
Merge pull request #903 from ParsePlatform/nlutsenko.push
4259c5d 
Cleanup PushController/PushRouter, remove raw mongo collection access.
@flovilmart flovilmart merged commit 4259c5d into master Mar 8, 2016
@nlutsenko nlutsenko deleted the nlutsenko.push branch March 8, 2016 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flovilmart flovilmart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nlutsenko @flovilmart @codecov-io @facebook-github-bot @drew-gross