Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Parse.GeoPoint test. #908

Merged
merged 2 commits into from
Mar 8, 2016
Merged

Fix flaky Parse.GeoPoint test. #908

merged 2 commits into from
Mar 8, 2016

Conversation

nlutsenko
Copy link
Contributor

I finally caught a condition when this fails - turns out that this is impacted by a state overflow from previous test, where upsert one the collection finishes after we deleted everything, ending up creating another column with a double geo point.
This is a valid fix for everyone regardless, because we are starting promises that can mutate schema, but are responding back from the server before the operation finishes. This merely awaits on it, thus eliminating the possibility of any state overflows.
Validated a fix by running tests over 5k times :)

cc @flovilmart, @DrewGross

and newcomer - @mcdonamp (you complained about it when building GCS 😁 )

@nlutsenko nlutsenko changed the title Fix flakt Parse.GeoPoint test. Fix flaky Parse.GeoPoint test. Mar 8, 2016
@codecov-io
Copy link

Current coverage is 90.92%

Merging #908 into master will not affect coverage as of 9a3a4c9

@@            master    #908   diff @@
======================================
  Files           72      72       
  Stmts         4154    4155     +1
  Branches       861     861       
  Methods          0       0       
======================================
+ Hit           3777    3778     +1
  Partial         10      10       
  Missed         367     367       

Review entire Coverage Diff as of 9a3a4c9

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor

Nice catch!

@nlutsenko nlutsenko self-assigned this Mar 8, 2016
nlutsenko added a commit that referenced this pull request Mar 8, 2016
@nlutsenko nlutsenko merged commit 8d10447 into master Mar 8, 2016
@nlutsenko nlutsenko deleted the nlutsenko.geoPoint branch March 8, 2016 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants