Move DatabaseController and Schema fully to adaptive mongo collection. #909
Conversation
| .then(() => { | ||
| let promises = insertedFields.map(fieldName => { | ||
| const mongoType = mongoObject.result[fieldName]; | ||
| return schema.validateField(className, fieldName, mongoType); |
There was a problem hiding this comment.
The reason I didn't use validateField originally is that it means you only need a single database operation to handle all the additions. Can you preserve that behaviour here?
There was a problem hiding this comment.
I can try, but am not sure why this should be blocking, since you don't have atomicity guarantees on deletions anyhow, meaning that the entire operation is not atomic...
Can this survive without having a single write for inserts? I can add a todo... 😁
There was a problem hiding this comment.
Yah there already a lot of failure modes but this does introduce a new failure mode where some fields are added and some are not. Although this eliminates the failure mode where one person adds a different schema in the middle and then it gets clobbered, so it's really just a trade from one failure mode to another, which is probably fine. In practise I doubt there would be many writers to the schema at the same time anyway.
nlutsenko
force-pushed
the
nlutsenko.databaseController
branch
from
f27431c to
49eb9df
Compare
|
@nlutsenko updated the pull request. |
Current coverage is
|
Move DatabaseController and Schema fully to adaptive mongo collection.
This is close to the final set of changes that will get us usage of mongo all through AdaptiveCollection API set.
This one moves Schema.js, DatabaseController to it as well as improves SchemasRouter API usage a little bit.