Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that ACLs propagate to before/after save hooks. #924

Merged
merged 2 commits into from
Mar 9, 2016

Conversation

nlutsenko
Copy link
Contributor

We were mutating the argument on database create/update operations, which is erasing an ACL key, due to the difference in mongo format.
Instead - do a deepcopy of the argument to make sure nothing gets mutated in-place.

Fixes #821, where ACL was not received in hooks.

@codecov-io
Copy link

Current coverage is 91.02%

Merging #924 into master will increase coverage by +0.01% as of 949fdcb

@@            master    #924   diff @@
======================================
  Files           72      72       
  Stmts         4163    4166     +3
  Branches       862     862       
  Methods          0       0       
======================================
+ Hit           3789    3792     +3
  Partial         10      10       
  Missed         364     364       

Review entire Coverage Diff as of 949fdcb

Powered by Codecov. Updated on successful CI builds.

drew-gross added a commit that referenced this pull request Mar 9, 2016
Make sure that ACLs propagate to before/after save hooks.
@drew-gross drew-gross merged commit 3723b9b into master Mar 9, 2016
@nlutsenko nlutsenko deleted the nlutsenko.hooks.acl branch March 9, 2016 01:03
@RaschidJFR RaschidJFR mentioned this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants