Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new schema collection type and replace all usages of direct mongo collection for schema operations. #943

Merged
merged 2 commits into from
Mar 10, 2016

Conversation

nlutsenko
Copy link
Contributor

This abstraction will give us an ability to use different syntax for Postgres, since schemas are not going to be represented as pure objects, but rather as tables and objects.

Also, cleans up the implementation and makes it more safe to build features on top.
Next stop - move schema api->mongo type conversions directly into MongoSchemaCollection.

@codecov-io
Copy link

Current coverage is 91.35%

Merging #943 into master will increase coverage by +0.05% as of 18a663a

@@            master    #943   diff @@
======================================
  Files           72      73     +1
  Stmts         4301    4324    +23
  Branches       862     863     +1
  Methods          0       0       
======================================
+ Hit           3927    3950    +23
  Partial         10      10       
  Missed         364     364       

Review entire Coverage Diff as of 18a663a

Powered by Codecov. Updated on successful CI builds.

nlutsenko added a commit that referenced this pull request Mar 10, 2016
Add new schema collection type and replace all usages of direct mongo collection for schema operations.
@nlutsenko nlutsenko merged commit 51862c1 into master Mar 10, 2016
@nlutsenko nlutsenko deleted the nlutsenko.schemaCollection branch March 10, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants