Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse tail fails when logs are missing (make it fail more gracefully?) #64

Closed
tdhopper opened this issue Sep 17, 2014 · 2 comments · Fixed by #69
Closed

sparse tail fails when logs are missing (make it fail more gracefully?) #64

tdhopper opened this issue Sep 17, 2014 · 2 comments · Fixed by #69

Comments

@tdhopper
Copy link
Contributor

sparse tail fails if any of the bash patterns (worker* supervisor* access* metrics* topo_name_*) is empty. This is probably an indication that something bad has happened, so maybe failure is the correct behavior.

Even if failure is the correct behavior, perhaps we could improve the error message from something more clear than:

 Fatal error: run() received nonzero return code 2 while executing!

Requested: cd /opt/storm/current/logs && ls worker* supervisor* access* metrics* topo_name_*
Executed: /bin/bash -l -c "cd /opt/storm/current/logs && ls worker* supervisor* access* metrics* topo_name_*"

For example, streamparse might tell which log files are missing?

@amontalenti
Copy link
Contributor

Maybe we should switch this to use find rather than shell globbing to avoid the error. I don't think this should throw an exception at all.

Also, for very big log file directories, find is probably more efficient than globbing.

@kbourgoin
Copy link
Member

It definitely shouldn't throw an exception. Consider a larger storm cluster of 20 or so nodes. We wouldn't have every topology on every machine, so that tail command needs to work even if the topology isn't there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants