Add flush method to LogStream #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue where I Bolt I was using that tried to flush stdout was crashing because it's not implemented in LogStream. This should fix that problem.
|
Just bumped into this problem again today, so it'd be awesome if you guys could merge this. 😄 |
|
|
kbourgoin
added a commit
that referenced
this pull request
Sep 25, 2014
Add flush method to LogStream
|
Not sure when we're cutting a new version, but it's in master for you now. |
|
Thanks! 👍 |
|
While we're talking about logging things, maybe you can take a peek at #58 as well. 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where a Bolt I was using that tried to flush stdout was crashing because it's not implemented in LogStream. This should fix that problem.