Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceControl MessageFailed events do not contain message bodies #4474

Closed
awright18 opened this issue Sep 26, 2024 · 1 comment
Closed

ServiceControl MessageFailed events do not contain message bodies #4474

awright18 opened this issue Sep 26, 2024 · 1 comment
Labels
Milestone

Comments

@awright18
Copy link
Contributor

awright18 commented Sep 26, 2024

Symptoms

Subscribing to MessageFailed events from ServiceControl.Contracts does not include the message body, even though the message is text, less than 85KB (small enough to avoid the Large Object Heap), and Full-Text indexing of message bodies is enabled.

Who's affected

Anyone subscribing to ServiceControl.Contracts MessageFailed event and trying to access the message body when using ServiceControl 5.0 or later.

Root cause

The transition to RavenDB 5 required changes in how the message body is stored in ServiceControl which were not reflected by matching changes to the code publishing external integration events.

Original report

Describe the bug

Description

When subscribing to ServiceControl events the MessageFailed events do not contain message bodies.

Expected behavior

MessageFailed events contain message bodies.

Actual behavior

MessageFailed events do not contain message bodies.

Versions

Please list the version of the relevant packages or applications in which the bug exists.

It was identified in 5.9 but is likely a problem in all 5.x versions.

Steps to reproduce

Follow the steps in subscribing to ServiceControl events in order to received failed messages

Throw an exception when handling a message in a message handler that is connected to ServiceControl

Relevant log output

No response

Additional Information

Workarounds

Possible solutions

Additional information

@awright18 awright18 added the Bug label Sep 26, 2024
@awright18 awright18 changed the title MessageFailed Integration events do not contain message bodies ServiceControl MessageFailed events do not contain message bodies Sep 26, 2024
@DavidBoike DavidBoike added this to the 5.10.0 milestone Sep 26, 2024
@DavidBoike
Copy link
Member

Will be fixed by #4475 and released as part of ServiceControl 5.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants