Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslashes not shown in message body #594

Closed
ramonsmits opened this issue Jul 25, 2016 · 9 comments · Fixed by #620
Closed

Backslashes not shown in message body #594

ramonsmits opened this issue Jul 25, 2016 · 9 comments · Fixed by #620
Assignees
Labels
Milestone

Comments

@ramonsmits
Copy link
Member

Backslashes in the body are not shown. Expected either one slash or an escaped (double slash)

{
  "OrderId": "123\ABC"
}

image

References:

@HEskandari
Copy link
Contributor

@ramonsmits this has been addressed as a part of #596. Here's how it looks now. Is it acceptable? Should we close the issue?

image

@adamralph
Copy link
Member

Does that mean we fixed both this bug and #596 in #620 ?

@HEskandari
Copy link
Contributor

That is my understanding @adamralph

@adamralph
Copy link
Member

OK. In that case, shall we close it, add it to the 1.5.8 milestone and update the release notes?

@adamralph adamralph self-assigned this Nov 10, 2016
@HEskandari
Copy link
Contributor

@adamralph I'm 👍 on that.

@adamralph
Copy link
Member

Closed in #620.

@adamralph
Copy link
Member

Done. I also:

@HEskandari
Copy link
Contributor

Excellent @adamralph!

@ramonsmits
Copy link
Member Author

@HEskandari That isn't just acceptable... that is great ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants